Use inheritance for Error messages. Allow passing a message into an Error, like StandardError allows

Author: jsmestad

lib/jsonapi/consumer/errors.rb

@@ -2,55 +2,45 @@ module JSONAPI::Consumer
   module Errors
     class ApiError < StandardError
       attr_reader :env
-      def initialize(env)
+      def initialize(message, env=nil)
+        super(message)
         @env = env
       end
     end
 
-    class ClientError < ApiError
-    end
-
-    class AccessDenied < ClientError
-    end
-
-    class NotAuthorized < ClientError
-    end
-
-    class ConnectionError < ApiError
-    end
+    class ClientError < ApiError; end
+    class AccessDenied < ClientError; end
+    class NotAuthorized < ClientError; end
+    class ConnectionError < ApiError; end
 
     class ServerError < ApiError
-      def message
-        "Internal server error"
+      def initialize(message, env=nil)
+        super("Internal server error", env)
       end
     end
 
     class Conflict < ServerError
-      def message
-        "Resource already exists"
+      def initialize(message, env=nil)
+        super("Resource already exists", env)
       end
     end
 
     class NotFound < ServerError
       attr_reader :uri
-      def initialize(uri)
+
+      def initialize(message, uri=nil)
+        super("Couldn't find resource at: #{uri.to_s}")
         @uri = uri
       end
-      def message
-        "Couldn't find resource at: #{uri.to_s}"
-      end
     end
 
     class UnexpectedStatus < ServerError
       attr_reader :code, :uri
       def initialize(code, uri)
+        super("Unexpected response status: #{code} from: #{uri.to_s}")
         @code = code
         @uri = uri
       end
-      def message
-        "Unexpected response status: #{code} from: #{uri.to_s}"
-      end
     end
-
   end
 end

lib/jsonapi/consumer/middleware/status.rb

@@ -12,7 +12,7 @@ def call(environment)
           end
         end
       rescue Faraday::ConnectionFailed, Faraday::TimeoutError
-        raise Errors::ConnectionError, environment
+        raise Errors::ConnectionError.new(nil, environment)
       end
 
       protected
@@ -21,17 +21,17 @@ def handle_status(code, env)
         case code
         when 200..399
         when 401
-          raise Errors::NotAuthorized, env
+          raise Errors::NotAuthorized.new(nil, env)
         when 403
-          raise Errors::AccessDenied, env
+          raise Errors::AccessDenied.new(nil, env)
         when 404
-          raise Errors::NotFound, env[:url]
+          raise Errors::NotFound.new(nil, env[:url])
         when 409
-          raise Errors::Conflict, env
+          raise Errors::Conflict.new(nil, env)
         when 400..499
           # some other error
         when 500..599
-          raise Errors::ServerError, env
+          raise Errors::ServerError.new(nil, env)
         else
           raise Errors::UnexpectedStatus.new(code, env[:url])
         end