Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible in systray anymore #24

Closed
kupiqu opened this issue Jun 4, 2017 · 9 comments
Closed

Not possible in systray anymore #24

kupiqu opened this issue Jun 4, 2017 · 9 comments

Comments

@kupiqu
Copy link

kupiqu commented Jun 4, 2017

Is it not possible to have PlayBar in the systray anymore?
I really liked that feature, to replace Plasma's default media player control... Would it be possible to get it back?

@kupiqu
Copy link
Author

kupiqu commented Jun 4, 2017

In particular I like that PlayBar, if in systray, is only present when needed, that is when players are running :)

@jsmitar
Copy link
Owner

jsmitar commented Jun 4, 2017

Disable it for this version, because it was very problematic and it did not look very good.
However I wish to add the feature again, but with a better Layout and a better behavior.

@kupiqu
Copy link
Author

kupiqu commented Jun 4, 2017

Previous version was working great in my system.

The only issue I experienced was that keyboard shortcuts stopped working when in addition to the playbar applet in the systray (via latte-dock), I added another one to the desktop (via plasma).

Looking forward for your new implementation of this feature, I'm sure it will be awesome! (do you have a tentative time plan for it?)

@jsmitar
Copy link
Owner

jsmitar commented Jun 4, 2017

Now I'm working on LatteDock, then I think that I can added the feature for the Tuesday and the Wednesday I will launch a small release.

The only issue I experienced was that keyboard shortcuts stopped working when in addition to the playbar applet in the systray (via latte-dock), I added another one to the desktop (via plasma).

This a curious issue, and is obvious because in such case the instance that manage the global shortcuts is duplicated, then occur a conflict in the actions.

I have to invent something to avoid this.

@jsmitar jsmitar closed this as completed in f6c7545 Jun 8, 2017
@jsmitar jsmitar reopened this Jun 8, 2017
@jsmitar
Copy link
Owner

jsmitar commented Jun 8, 2017

@kupiqu The placement in systemtray was enabled, tell me what you think?

@kupiqu
Copy link
Author

kupiqu commented Jun 8, 2017

I got a warning while running cmake:

CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:58 (message):
warnings during generation of metainfo for audoban.applet.playbar.systray:
PlayBar2/plasmoid-systray/../plasmoid-systray
has enabled «NoDisplay»

not sure if this is important or not...

@jsmitar
Copy link
Owner

jsmitar commented Jun 8, 2017

Please ignore it, such property is totally necessary for avoid the entries duplicates of PlayBar on widget explorer.
Don't worry

@kupiqu
Copy link
Author

kupiqu commented Jun 8, 2017

It works great!

Perhaps the only thing is that it would be nice that settings that do not apply in systemtray appeared greyed out (with a bonus of a tooltip explaining why, perhaps?)

@jsmitar
Copy link
Owner

jsmitar commented Jun 8, 2017

Perhaps the only thing is that it would be nice that settings that do not apply in systemtray appear greyed out (with a bonus of a tooltip explaining why, perhaps?)

I'll keep it in mind.

@jsmitar jsmitar closed this as completed Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants