Refactor to allow setting custom autoload entry #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* json-mode.el (json-mode-standard-file-ext): Refactor the `auto-mode-alist' to extract common JSON extensions. (json-mode--update-auto-mode): Add an inline function to set the `auto-mode-alist` regexp. (json-mode-auto-mode-list): Add the customization option to automatically open file names as JSON. Note that each time the option is changed, it updates the `auto-mode-alist` entry for `json-mode`. (json-mode--auto-mode-entry): Add a variable to cache the `json-mode` `auto-mode-list` entry.
|
However, I don't see any reason not to load the package if the user set |
* json-mode.el (json-mode--update-auto-mode): Remove argument that appended the new auto-mode-alist JSON entry.
|
This is great @notetiene - something I've wanted for a while but never got around to. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting custom files to be loaded automatically with
json-mode. I saw that some files were added recently, but it doesn't cover much of the file names we can get in web development.Unless the customization option is set from
custom-set-variables, the package is not loaded until anautoloadfunction is called.