-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $schema keywords to actual schemas #557
Comments
This might better allow expressing some optional tests like |
This is a duplicate of #311 -- can you express your support there instead? I'm going to reiterate what I write below there too as my opinion and we can see what others think. To me, I don't feel the recommendation really applies strongly here, for reasons I intended to describe in #324 -- namely, what I think we should optimize for in the test suite is readability, not perfection -- and while that recommendation is perfect for schemas in isolation which otherwise wouldn't know what On the other hand I do like:
since it seems nice to be able to rely on something someone already needs to support, but I don't think, again in my opinion, that this will work really. Because the test suite will always need to also include a test where But yeah happy to either elaborate myself, or hear again from others. I know Greg and Henry may still be in favor of this. |
According to the specification, JSON Schema definitions are recommended to have a
$schema
keyword. Instead of relying on implementors to guess which one should be used for every folder, would it make sense to manually set$schema
in all the tests?This would also open the door for better testing vocabularies, where you have tests with certain meta-schemas that define or not define certain vocabularies.
The text was updated successfully, but these errors were encountered: