Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Search and remove any from codebase #1034

Open
DhairyaMajmudar opened this issue Oct 18, 2024 · 4 comments
Open

🐛 Bug: Search and remove any from codebase #1034

DhairyaMajmudar opened this issue Oct 18, 2024 · 4 comments
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. Hacktoberfest Issues accepeted Hacktoberfest'24 Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@DhairyaMajmudar
Copy link
Member

Describe the bug

-> While performing a quick VS Code search its found that there are several places in the codebase where any datatype is used,
-> Using any in place of correct data type alters the strictness of typescript hence its a not a good practice to use them.

-> The main objective of this issue is to find the files where any keyword is used and replace them with the correct data type definition.

Steps To Reproduce

Do a VSCode Search to find the files using any keyword. They are mostly used in component files

Expected Behavior

There should be no use of any keyword in the codebase

Screenshots

No response

Device Information [optional]

- OS: Linux (Debian)
- Browser: Firefox
- version: Latest

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@DhairyaMajmudar DhairyaMajmudar added 🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. labels Oct 18, 2024
@DhairyaMajmudar DhairyaMajmudar added Status: Available No one has claimed responsibility for resolving this issue. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Hacktoberfest Issues accepeted Hacktoberfest'24 and removed Status: Triage This is the initial status for an issue that requires triage. labels Oct 18, 2024
@Asymtode712
Copy link

@DhairyaMajmudar I would like to work on this issue.....Please assign it to me

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Oct 18, 2024
@DhairyaMajmudar
Copy link
Member Author

@DhairyaMajmudar I would like to work on this issue.....Please assign it to me

Looking forward for your PR, also at some instances you might need to create a custom data type at that moment pls. take care with the naming, Best wishes 🚀

@Asymtode712
Copy link

Asymtode712 commented Oct 18, 2024

@DhairyaMajmudar I am done with most of the components....I have a doubt: Do I need to remove the any keywords from the pages directory too....

@DhairyaMajmudar
Copy link
Member Author

@DhairyaMajmudar I am done with most of the components....I have a doubt: Do I need to remove the any keywords from the pages directory too....

yep, if those files have any keyword then pls. remove from there also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Hacktoberfest Issues accepeted Hacktoberfest'24 Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
Status: In Progress
Development

No branches or pull requests

2 participants