-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements: Typos and grammatical errors in README.md #1081
base: main
Are you sure you want to change the base?
Conversation
Fixed some typos, grammatical errors and added extra info in places for extra clarity
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1081 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
Ready to merge 👍 |
Wow! Pretty quick, Thanks for the PR @IyaadDev... You can use this PR for pushing other changes too. |
Co-authored-by: Dhairya Majmudar <124715224+DhairyaMajmudar@users.noreply.github.com>
Later throughout the course of this week hopefully I'll be able to review the rest of the docs to suggest changes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I left just 1 single comment.
Good changes!
<br /> | ||
<a href = "https://github.com/json-schema-org/website/graphs/contributors"> | ||
<img src = "https://contrib.rocks/image?repo=json-schema-org/website"/> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this markdown, like on line 88?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Greg Dennis <gregsdennis@yahoo.com>
Co-authored-by: Greg Dennis <gregsdennis@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What kind of change does this PR introduce?
Issue Number:
If relevant, did you update the documentation?
Summary
*Feel free to check if there's anything I've missed out on*