refactor: update BaseConstraint.php to PHP 7.2 language level (#826)

This pull request refactors the `BaseConstraint` class in the
`JsonSchema` package to improve code readability, enforce immutability,
and align with modern PHP practices. The changes include replacing
anonymous functions with static closures, updating type casting, and
removing outdated comments.

### Code modernization and immutability:

* Replaced anonymous functions with `static` closures in methods like
`addError`, `addErrors`, and `convertJsonPointerIntoPropertyPath` to
enforce immutability and improve performance.
[[1]](diffhunk://#diff-05cd63f6b003f185a215e10402525e33d94466ec4d83a685c5a6ccd1befcf921L53-R48)
[[2]](diffhunk://#diff-05cd63f6b003f185a215e10402525e33d94466ec4d83a685c5a6ccd1befcf921L81-R75)
[[3]](diffhunk://#diff-05cd63f6b003f185a215e10402525e33d94466ec4d83a685c5a6ccd1befcf921L167-R162)
* Updated type casting for better readability and adherence to modern
PHP conventions, e.g., `(string)` instead of `strval`.

### Code readability and cleanup:

* Removed outdated docblock comments and unnecessary annotations, such
as the `@return` tag in `convertJsonPointerIntoPropertyPath`.
* Replaced `\JSON_ERROR_NONE` with the `JSON_ERROR_NONE` constant for
consistency with the `use` statement.

### Other improvements:

* Adjusted the `json_decode` call to explicitly set the `associative`
parameter to `false` for clarity.

Author: DannyvdSluijs

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Added extra breaking change to UPDATE-6.0.md regarding BaseConstraint::addError signature change ([#823](https://github.com/jsonrainbow/json-schema/pull/823))
 - Update constraint class to PHP 7.2 language level ([#824](https://github.com/jsonrainbow/json-schema/pull/824))
+- Update base constraint class to PHP 7.2 language level ([#826](https://github.com/jsonrainbow/json-schema/pull/826))
 
 ### Added
 - Introduce 32 bits CI workflow on latest php version ([#825](https://github.com/jsonrainbow/json-schema/pull/825))

src/JsonSchema/Constraints/BaseConstraint.php

@@ -2,15 +2,9 @@
 
 declare(strict_types=1);
 
-/*
- * This file is part of the JsonSchema package.
- *
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
-
 namespace JsonSchema\Constraints;
 
+use const JSON_ERROR_NONE;
 use JsonSchema\ConstraintError;
 use JsonSchema\Entity\JsonPointer;
 use JsonSchema\Exception\InvalidArgumentException;
@@ -50,8 +44,8 @@ public function addError(ConstraintError $constraint, ?JsonPointer $path = null,
         $name = $constraint->getValue();
         $error = [
             'property' => $this->convertJsonPointerIntoPropertyPath($path ?: new JsonPointer('')),
-            'pointer' => ltrim(strval($path ?: new JsonPointer('')), '#'),
-            'message' => ucfirst(vsprintf($message, array_map(function ($val) {
+            'pointer' => ltrim((string) ($path ?: new JsonPointer('')), '#'),
+            'message' => ucfirst(vsprintf($message, array_map(static function ($val) {
                 if (is_scalar($val)) {
                     return is_bool($val) ? var_export($val, true) : $val;
                 }
@@ -78,7 +72,7 @@ public function addErrors(array $errors): void
         if ($errors) {
             $this->errors = array_merge($this->errors, $errors);
             $errorMask = &$this->errorMask;
-            array_walk($errors, function ($error) use (&$errorMask) {
+            array_walk($errors, static function ($error) use (&$errorMask) {
                 if (isset($error['context'])) {
                     $errorMask |= $error['context'];
                 }
@@ -95,10 +89,8 @@ public function getErrors(int $errorContext = Validator::ERROR_ALL): array
             return $this->errors;
         }
 
-        return array_filter($this->errors, function ($error) use ($errorContext) {
-            if ($errorContext & $error['context']) {
-                return true;
-            }
+        return array_filter($this->errors, static function ($error) use ($errorContext) {
+            return (bool) ($errorContext & $error['context']);
         });
     }
 
@@ -120,7 +112,7 @@ public function isValid(): bool
     }
 
     /**
-     * Clears any reported errors.  Should be used between
+     * Clears any reported errors. Should be used between
      * multiple validation checks.
      */
     public function reset(): void
@@ -145,15 +137,15 @@ public function getErrorMask(): int
     public static function arrayToObjectRecursive(array $array): object
     {
         $json = json_encode($array);
-        if (json_last_error() !== \JSON_ERROR_NONE) {
+        if (json_last_error() !== JSON_ERROR_NONE) {
             $message = 'Unable to encode schema array as JSON';
             if (function_exists('json_last_error_msg')) {
                 $message .= ': ' . json_last_error_msg();
             }
             throw new InvalidArgumentException($message);
         }
 
-        return (object) json_decode($json);
+        return (object) json_decode($json, false);
     }
 
     /**
@@ -164,13 +156,10 @@ public static function jsonPatternToPhpRegex(string $pattern): string
         return '~' . str_replace('~', '\\~', $pattern) . '~u';
     }
 
-    /**
-     * @return string property path
-     */
     protected function convertJsonPointerIntoPropertyPath(JsonPointer $pointer): string
     {
         $result = array_map(
-            function ($path) {
+            static function ($path) {
                 return sprintf(is_numeric($path) ? '[%d]' : '.%s', $path);
             },
             $pointer->getPropertyPaths()