Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sibling properties of $ref are not ignored #436

Closed
erayd opened this issue Jun 21, 2017 · 1 comment
Closed

Sibling properties of $ref are not ignored #436

erayd opened this issue Jun 21, 2017 · 1 comment

Comments

@erayd
Copy link
Contributor

erayd commented Jun 21, 2017

According to the spec:

An object schema with a "$ref" property MUST be interpreted as a "$ref" reference. The value of the "$ref" property MUST be a URI Reference. Resolved against the current URI base, it identifies the URI of a schema to use. All other properties in a "$ref" object MUST be ignored.

The current behavior is to process all properties regardless of whether $ref is present, which is a bug and contrary to the spec.

This needs to be fixed for 6.0.0, and should not be backported - it's a bugfix, but will break known behavior that some people may be depending on.

Big thanks to @johannes-see for noticing this in #435 👍.

@erayd
Copy link
Contributor Author

erayd commented Jun 21, 2017

Fixed in #437.

@erayd erayd closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant