Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: type order in 'allOf' has an impact #712

Open
kroc702 opened this issue Feb 13, 2024 · 3 comments
Open

bug: type order in 'allOf' has an impact #712

kroc702 opened this issue Feb 13, 2024 · 3 comments
Labels

Comments

@kroc702
Copy link

kroc702 commented Feb 13, 2024

Hello,
When validate with multiple schema using 'allOf', definition order has a behavior impact.
cf attached code to test
testSchemaValidator2.zip

Correct:

input value: "true"
schema: {
    "allOf": [
        {
            "type": "string"
        },
        {
            "type": "boolean"
        }
    ]
}
value is valid

reverse order lead to incorrect validation:

input value: "true"
schema: {
    "allOf": [
        {
            "type": "boolean"
        },
        {
            "type": "string"
        }
    ]
}
Boolean value found, but a string is required
Failed to match all schemas
@kroc702
Copy link
Author

kroc702 commented Feb 13, 2024

I forget to mention version:

            "name": "justinrainbow/json-schema",
            "version": "v5.2.13",
            "source": {
                "type": "git",
                "url": "https://github.com/justinrainbow/json-schema.git",
                "reference": "fbbe7e5d79f618997bc3332a6f49246036c45793"
            },

@DannyvdSluijs
Copy link
Collaborator

@kroc702 thanks for the report. Based on your schema provided it seems no input data will be valid ever as the a single value cannot be boolean and string at the same time. Using https://jsonschemalint.com/ you can see that both versions of you schema should raise errors whereas you mention that in both cases you expect them to be valid.

@kroc702
Copy link
Author

kroc702 commented Feb 14, 2024

Well it's a choice, your choice ;)
As php is loosely typed, it doesn't hurt me to validate the strings "true" or "1" as boolean or number. Changing this behavior may be a braking change for the lib.

We just need a consistent behavior with all types and order shouldn't impact behavior of any/all/oneOf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants