-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change website
to url
#148
Comments
+1 |
2 similar comments
+1 |
+1 |
+1 |
bump @thomasdavis |
+1 shall we merge? :) |
I'm indifferent to this - and I don't mind merging it, but can someone give me reason as to why they prefer 'url'? |
A url could point to a resource, an app or similar, it does not need to be a website. In addition to that it makes all urls consistently with naming them url. |
Sounds good. We'll merge this when we can. |
Sorry, to add a new comment. Just to say that I think about @stp-ip sidenote and I really like it. It will add more cohesion with bibjson. I feel that it is more "human-compliant".
Since every body seems agree with URL. I think we should keep it for the current version, but , at least, keep this idea for the next one. |
@aloisdg hmm, interesting. I do like it. Let's re-open and rename the issue to url -> source so we don't forget 😄 |
Glad you like it too 😄 By the way, the new title shouldn't be "How to rename website?" or "What would be a better alternative for website?" Call an url "url" is like called a string "string", isn't it? |
@aloisdg I think there was a PR for this which already got merged in, so the property is called Url now (used to be website). That's why "Change url to (bibJSON) source" made sense to me 😄 |
@olivif The conversation was created for an older version. I think that we should read it straight. With the current title, it seems that the fourth first commenters agree with the switch to "source". Thats not right. |
@aloisdg yeah I agree, it's confusing. maybe we should create a new issue instead of reusing this? 😄 |
It's a different issue in my opinion. Most likely 2-3:
Closing as the old issue is done and anything else should start with a clean issue. |
No description provided.
The text was updated successfully, but these errors were encountered: