Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete key stops working #6

Open
mrowles opened this issue Jul 4, 2018 · 4 comments
Open

Delete key stops working #6

mrowles opened this issue Jul 4, 2018 · 4 comments

Comments

@mrowles
Copy link
Contributor

mrowles commented Jul 4, 2018

If you play around with adding text, adding placeholders (required and non) and pressing delete enough, pretty quickly it starts to bug out and you see duplicate placeholders. Also seems to make the text-cursor disappear, but this solution might solve this particular secondary issue.

@jspaine
Copy link
Owner

jspaine commented Jul 8, 2018

Thanks for the report, but I can't reproduce this. What Quill version are you using? And how quickly does it happen (rough amount text/placeholders/delete presses)?

The cursor disappearing can happen with Quill <= 1.3.0 when it's positioned after a placeholder that's the last element on a line, I've been meaning to add the InlineEmbed code from recent Quill versions to this to better support earlier Quill versions.

@mrowles
Copy link
Contributor Author

mrowles commented Jul 8, 2018

This happened on Chrome, latest. Versions below:

"quill": "^1.3.6",
"quill-placeholder-module": "^0.3.1",

Like I said, it was pretty random occurrences, I'll try and replicate exactly tonight and list the steps below. It might not be a huge issue to be honest, as the last few times it's happened it's been on required fields, which I won't be using.

@jspaine
Copy link
Owner

jspaine commented Jul 8, 2018

Thanks, there could definitely be some issues with the required placeholders, I'll look into it a bit.

@xeger
Copy link

xeger commented Oct 17, 2019

I just saw the same thing with a required field. Doesn't seem to happen with non-required fields. I'll try to diagnose.

I'm using quill 1.3.6 and also using react-quill as a wrapper.

Happens when the document contains only 2 elements, both placeholders: a nonrequired thing followed by a required thing. Positioning cursor to end of doc & hitting backspace, causes the required field to dupe.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants