Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming: AnnotationFileElementTypes#getDeclAnnotations change #45

Open
wmdietl opened this issue Dec 14, 2023 · 2 comments
Open

Upstreaming: AnnotationFileElementTypes#getDeclAnnotations change #45

wmdietl opened this issue Dec 14, 2023 · 2 comments

Comments

@wmdietl
Copy link
Collaborator

wmdietl commented Dec 14, 2023

Understand what this change achieved and see whether it is still necessary. If it is, find a way to upstream.

@cpovirk
Copy link
Collaborator

cpovirk commented Dec 14, 2023

I think this is part of what #11 is about. (It refers to 719b6f0.) But as the commit messages of the various commits on that issue suggest, I never really understood what I was doing... :) So I provide that link as a pointer toward some of the relevant commits, not because it answers any questions or eliminates the need for this current issue.

(Also, this is an example of some code that we might be able to get by without if we were willing to disable stub-file reading.)

@wmdietl
Copy link
Collaborator Author

wmdietl commented Dec 14, 2023

Thanks for the pointer! When looking at the blame I just saw a merge commit and missed the earlier explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants