Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level resolutions #172

Closed
guybedford opened this issue Aug 18, 2022 · 2 comments
Closed

Top-level resolutions #172

guybedford opened this issue Aug 18, 2022 · 2 comments
Assignees

Comments

@guybedford
Copy link
Member

We need to ensure "resolutions" apply for top-level installs, these still seem to be getting missed somehow.

@Bubblyworld
Copy link
Contributor

@guybedford Do you know/remember how to reproduce this? Setting "resolutions" on the generator options seems to work fine for me for top-level installs, secondary installs, and linking. For instance, this works:

let generator = new Generator({
  mapUrl: import.meta.url,
  env: ["production", "browser"],
  resolutions: {
    semver: "6.2.0",
  },
});

await generator.install("semver@latest");
let json = generator.getMap();
assert.ok(json.imports["semver"]);
assert.ok(json.imports["semver"].includes("6.2.0")); // passes fine

@guybedford
Copy link
Member Author

Tests included, closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants