Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Module not found: https://cdn.jsdelivr.net/npm/dayjs@1.11.11/locale/en #355

Closed
colinmollenhour opened this issue May 13, 2024 · 3 comments · Fixed by #359
Closed
Labels
enhancement New feature or request

Comments

@colinmollenhour
Copy link

This error was generated on generator.jspm.io by adding the dependency "@cubejs-client/core". It works when jspm.io is the CDN but not for jsdelivr. However, jsdelivr does host the file using the .js extension here: https://cdn.jsdelivr.net/npm/dayjs@1.11.11/locale/en.js

Error: Module not found: https://cdn.jsdelivr.net/npm/dayjs@1.11.11/locale/en imported from https://cdn.jsdelivr.net/npm/@cubejs-client/core@0.35.23/dist/cubejs-client-core.esm.js
@guybedford guybedford transferred this issue from jspm/project May 21, 2024
@guybedford
Copy link
Member

I've transferred this issue to the generator repo as an enhancement for supporting extension searching for exports paths that fail their original request.

CommonJS supports this pattern in Node.js, so it seems a sensible pattern to support in the name of compatibility.

@guybedford
Copy link
Member

Fixed in #359, will aim to post a generator release this week.

@colinmollenhour
Copy link
Author

Thanks @guybedford !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants