No test coverage for oldValue in events

[testower]

I just noticed that the redisson implementation doesn't implement oldValue in cache entry events, but it still passed the tck tests. I just had a look at the tests coverage for events, and it doesn't seem like it's covered. Should it be?

[cruftex]

Does not implement or does not do? Did you set CacheEntryListenerConfiguration#isOldValueRequired()?
Which version of redisson and TCK are you referring to?

[testower]

Redisson does not implement oldValue. It's confirmed by the maintainer.

[testower]

My question isn't really about Redisson, but about the tck tests. It looks like they don't cover oldValue - and is that deliberate or an oversight?

[cruftex]

Just checked it. The assertions were missing missing up to TCK 1.1.0. TCK 1.1.1 was released to add these checks.
Changes were done by @vbekiaris in
2cb42a3
a3f8292

I have not double checked these changes. Does redisson pass on TCK 1.1.1?

[testower]

I suppose this (https://github.com/cruftex/jsr107-test-zoo/blob/master/redisson-V2-test/pom.xml#L10) means they have only run against 1.1.0. Thanks for pointing that out 👍

[cruftex]

Oh. Maybe I should do an update on the "test-zoo". Feel free to send a PR. It seems there is not much interest lately.

A note: Passing the TCK does not mean the implementation is compliant to the spec or in other words: its not sufficient. The TCK tries to test a lot, but does not cover everything, e.g. the whole concurrent behavior is not covered.

[cruftex]

@testower, why close?

[testower]

Sorry about that, I closed the issue because my question was about coverage of old value in events, which you have answered: these are now covered by tests. If you think the issue should remain open to update the test-zoo that's fine. I haven't looked closely at how to run these.