Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace group separator character with blank string #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace group separator character with blank string #15

wants to merge 1 commit into from

Conversation

stamminator
Copy link

...instead of with a . symbol.

Fixes #12.

@stamminator
Copy link
Author

Despite what Travis is reporting, it looks like my changes are failing the unit tests.

Chrome 73.0.3683 (Windows 10.0.0) ngInputCurrency ngInputCurrency should first update the model once the element is blurred. FAILED
        Expected 12350 to be 123.5.
            at UserContext.<anonymous> (C:/repos/ng-input-currency/test/ng-input-currency.js:109:27)
        Expected 12350 to be 123.5.
            at UserContext.<anonymous> (C:/repos/ng-input-currency/test/ng-input-currency.js:114:27)
Chrome 73.0.3683 (Windows 10.0.0) ngInputCurrency ngInputCurrencyService .preformatValue should remove the CURRENCY_SYM if its in the value FAILED
        Expected '12345' to be '123.45'.
            at UserContext.<anonymous> (C:/repos/ng-input-currency/test/ng-input-currency.js:156:122)
        Expected '12345' to be '123.45'.
            at UserContext.<anonymous> (C:/repos/ng-input-currency/test/ng-input-currency.js:157:122)
Chrome 73.0.3683 (Windows 10.0.0) ngInputCurrency ngInputCurrencyService .preformatValue should change the GROUP_SEP to a . if the GROUP_SEP only exists one place and DECIMAL_SEP does not exists FAILED
        Expected '12345' to be '123.45'.
            at UserContext.<anonymous> (C:/repos/ng-input-currency/test/ng-input-currency.js:161:85)
Chrome 73.0.3683 (Windows 10.0.0): Executed 13 of 13 (3 FAILED) (0.026 secs / 0 secs)

I will try to figure out what's wrong. In the meantime @jstroem, if you feel like checking it out as well, I have a demo with my changes running at https://stackblitz.com/edit/angularjs-p7wcc8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Value of ng-model becomes undefined on submit
1 participant
@stamminator