Fix repair=True proc args (stderr being captured)

jsvine · Jun 7, 2024 · 70534a7 · 70534a7
1 parent 2e9819c
commit 70534a7
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pdfplumber/repair.py b/pdfplumber/repair.py
@@ -25,6 +25,7 @@ def _repair(
 
     repair_args = [
         executable,
+        "-sstdout=%stderr",
         "-o",
         "-",
         "-sDEVICE=pdfwrite",
@@ -41,14 +42,16 @@ def _repair(
         stdin = path_or_fp
         repair_args += ["-"]
 
-    stdout, stderr = subprocess.Popen(
+    proc = subprocess.Popen(
         repair_args,
         stdin=subprocess.PIPE if stdin else None,
         stdout=subprocess.PIPE,
         stderr=subprocess.PIPE,
-    ).communicate(stdin.read() if stdin else None)
+    )
+
+    stdout, stderr = proc.communicate(stdin.read() if stdin else None)
 
-    if len(stderr):
+    if proc.returncode:
         raise Exception(f"{stderr.decode('utf-8')}")
 
     return BytesIO(stdout)