Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react/destructuring-assignment ignoreClassFields not working correctly #1982

Closed
zslabs opened this issue Sep 13, 2018 · 1 comment · Fixed by #1983
Closed

react/destructuring-assignment ignoreClassFields not working correctly #1982

zslabs opened this issue Sep 13, 2018 · 1 comment · Fixed by #1983
Labels
bug

Comments

@zslabs
Copy link

zslabs commented Sep 13, 2018 •
edited
Loading

Using the following config:

"rules": {
  "react/destructuring-assignment": [2, "always", { "ignoreClassFields": true }]
}

This still throws an error:

class Input extends React.Component {
  id = `${this.props.name}-${generateUUID()}`;
 ...

This looks like it was introduced in #1909 but I'm not seeing this actually working.
@ljharb
Copy link
Member

ljharb commented Sep 13, 2018

cc @alexzherdev

@ljharb ljharb added the bug label Sep 13, 2018
@alexzherdev alexzherdev mentioned this issue Sep 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] destructuring-assignment: handle nested props usage alexzherdev/eslint-plugin-react
2 participants
@ljharb @zslabs