You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Starting in 7.23.0, the jsx-no-target-blank rule will fail when warnOnSpreadAttributes is false and there's a spread before a non-_blank target, which is supposed to pass even if warnOnSpreadAttributes is true.
Example:
When warnOnSpreadAttributes is false (or default):
Starting in 7.23.0, the jsx-no-target-blank rule will fail when
warnOnSpreadAttributes
is false and there's a spread before a non-_blank
target, which is supposed to pass even ifwarnOnSpreadAttributes
is true.Example:
When
warnOnSpreadAttributes
is false (or default):Would fail, while
would pass. If
warnOnSpreadAttributes
was true, both would fail.I believe the issue is the
if/elseif
logic here:https://github.com/yannickcr/eslint-plugin-react/blob/v7.23.1/lib/rules/jsx-no-target-blank.js#L149
The text was updated successfully, but these errors were encountered: