jsx-curly-brace-presence conflicts with no-unescaped-entities

[ntkoopman]

With both jsx-curly-brace-presence and no-unescaped-entities turned on

<script>{`window.foo = "bar"`}</script>

is fixed into

<script>window.foo = "bar"</script>

which works fine, but will give a warning/error on no-unescaped-entities.

It is my understanding that jsx-curly-brace-presence should not be triggering on this code, since the documentation says:

If the rule is set to get rid of unnecessary curly braces(JSX expression) and there are characters that need to be escaped in its JSX form, such as quote characters, forbidden JSX text characters, escaped characters and anything that looks like HTML entity names, the code will not be warned because the fix may make the code less readable.

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-brace-presence.md

[aprilmintacpineda]

This is still happening though.

After fixing the jsx-curly-brace-presence error

[ljharb]

@aprilmintacpineda can you be sure you’re on the latest version, and file a new issue if it’s still a problem?

[musjj]

It looks like that the special casing only considers backticks but not normal quotes.

This triggers a lint error:

<p>{"'"}</p>

But this doesn't:

<p>{`'`}</p>

[ljharb]

@musjj thanks, can you file a new issue for that one?

[musjj]

Made a new issue: #3801