Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.async() doesn't honor future(thisArg) #7

Open
tcf909 opened this issue Sep 9, 2016 · 0 comments
Open

.async() doesn't honor future(thisArg) #7

tcf909 opened this issue Sep 9, 2016 · 0 comments

Comments

@tcf909
Copy link

tcf909 commented Sep 9, 2016

When using .async() to turn a sync function in to an async one, the return function from .async() does not allow a this arg to be applied, because the cxt variable is always used.

"cxt = cxt || this;"

needs to be added right below:

"var args = arguments, cb = args[args.length-1];"

in syncho.js (at line 34)

This allows future() to set a thisArg when using .async() without .async(cxt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant