-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity optional dependencies as packages in their own right #4
Comments
My only concern is if this might break Chocolatey convention. The target support and other parameters aren't applications in their own right; simply extensions to Unity's functionality. An analogy is the VirtualBox Extension Pack for VirtualBox. In those cases, a separate package isn't made. |
I've asked the chocolatey team via gitter. My use-case is that my company wants to create an installer package for their product, and their product can require Unity, with particular optional extras installed. The version of Unity depended on changes with our own product - ie, we might release a new version and only support x-y version of Unity. Installing via package manager drastically reduces the complexity of the initial user onboarding and ongoing maintenance. |
@jtcmedia According to the chocolatey team creating one package per optional extra would be fine. See conversation linked. |
If they aren't completely standalone it makes sense for the additional packages to depend on Unity. That is similar to how KeePass-keepasshttp plugin and the KeePass language files work. |
I believe @petemounce wants the option to install these additional packages as parameters to Unity in addition to the usual cist. Is there any issue with doing that @dragon788 ? |
No; I'd like to be able to list the unity extras as individual dependencies of my package, to avoid needing to use the See https://chocolatey.org/packages/spatial _> dependencies.json. I want to list the unity extras that I depend on as individual dependencies. |
I issued one PR per package in the thinking that that would be easier to review. I
|
Do you still need the 5.5.0 version of these? Otherwise I have to submit two versions for every package. |
I think probably not; thanks. I took a look at the auto updater and decided it wasn't worth it; we'll be supporting 5.5.1 soon enough. |
All the 5.5.1 packages have been submitted and approved so I am going to close this issue now. |
I've seen that it's possible to install Unity optional dependencies via additional parameters when installing the unity package (eg
/sa
etc). This is great.However, if I create a package that takes unity as a dependency, then because of chocolatey/choco#488 I cannot specify those additional parameters (let's say that my package wants unity with both linux and osx build support).
Therefore - would it be possible to get those optional dependencies as packages in their own right? Or, would you be open to a PR that generated a package for each of these dependencies, for you to then push when there are new versions? It looks like your
update.ps1
could be adjusted to do that.The text was updated successfully, but these errors were encountered: