-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module not installable with npm #44
Comments
This can be reproduced by using the sveltekit demo app and using the 'svelte-adapter-firebase' adapter in the current version. When I copied the package.json ('my-app/node_modules/.pnpm/svelte-adapter-firebase@0.6.1_svelte@3.38.2+vite@2.2.4/node_modules/svelte-adapter-firebase/package.json) to 'my-app/node_modules/.pnpm/svelte-adapter-firebase@0.6.1_svelte@3.38.2+vite@2.2.4/node_modules/svelte-adapter-firebase/src/package.json' the error disappeared. But the deployment to cloud run did not work after that because of the error described in this issue. @jthegedus Should I add a separate issue for this? |
I think this will be the result of the same issue. I thought i was able to force development to occur with I will fix momentarily. I need to work out #24 as it would likely pick up these issues |
@nhe23 You will need to test Cloud Run with the changes in |
I will work on #24 next so these types of issues get caught sooner. Apologies 🙏 |
🎉 This issue has been resolved in version 0.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I just installed the new version and it is now installable with npm. However running |
@nhe23 Can you open a new Issue? Also, I no longer compile the adapter, so feel free to go to that |
🎉 This issue has been resolved in version 0.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 0.6.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@nhe23 I'll get this right eventually, try that new version. |
Describe the bug
Current version 0.6.1 is not installable with npm. When I use pnpm it works. However the container does not build on CloudRun because it also has this problem.
To Reproduce
npm i
Expected behavior
npm install should work and container should build on CloudRun
Screenshots
The text was updated successfully, but these errors were encountered: