Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Run container can't be deployed because of devDependencies #54

Closed
nhe23 opened this issue May 11, 2021 · 2 comments
Closed

Cloud Run container can't be deployed because of devDependencies #54

nhe23 opened this issue May 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@nhe23
Copy link

nhe23 commented May 11, 2021

Describe the bug
Cloud Run Container does not start because of several issues with dependencies/scripts.

To Reproduce
1.Initialize svelte kit demo app
2. Add "svelte-adapter-firebase": "^0.6.3" as devDependency in package.json and configure the adapter as described in the docs
3. npm i
4. fix #53 locally & build the project
5. deploy to cloud run

Expected behavior
Cloud Run container should start

Screenshots
image

Additional context
Removing the devDependencies from the generated package.json in .mysitessr and removing all scripts but the 'start' script seem to fix this problem (At least the container is deployed).

@jthegedus jthegedus added the bug Something isn't working label May 11, 2021
@jthegedus
Copy link
Owner

The bug here is that the wrong package.json is being detected and used. Fix incoming.

@jthegedus
Copy link
Owner

Fixed in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants