Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column formatters #15

Closed
jtorjo opened this issue Jan 5, 2016 · 3 comments
Closed

Column formatters #15

jtorjo opened this issue Jan 5, 2016 · 3 comments

Comments

@jtorjo
Copy link
Owner

jtorjo commented Jan 5, 2016

This should basically work for both the view and the details pane (for instance, an xml msg could be shown in a friendly manner)
But for now, I may want to print several lines into one?

Column formatters should be allowed to have context (and eventually have settings based on which they do the formatting)

  • for instance, i could specify, in settings -> what colors to apply to the text
  • they need to be applied in such a way that they can add/modify colors of the text itself (or bold/italic etc.)
  • Tuple<int,int,print_info> -> needs to become a class, so that i can deal with it in an easier fashion -- need to be able to easily iterate through all "prints" -> like in description_ctrl.show_sub_item (to make generic)

Need to be able to easily give colors (defaults) to certain colors, such a green-like-in-VS for line numbers, some color for dates and so on.

Again, the column formatter must be able to have context so for instance I could even be able to mark visually times from minute to minute (like, when minute changes, change color) - this should only happen for the filters are run (so that you can have filters set the line color TOTHINK)

TODO:

  • in addition to the message to write, i need to allow extra information, such as alignment.
  • i have to be able to set a column formatter for "all" columns, and for specific columns: however, i may want to set the order of these columns (for instance, a certain formatter to be applied to all columns before another one is applied to a specific column, etc.). Thus, I should be able to assign several formatters to the same column(s). Probably the easiest is to just have an "order" setting (integer). This also means that for a certain column (or for all), i should be able to have several formatters
  • i need to be able to allow for both bg and fg
@jtorjo
Copy link
Owner Author

jtorjo commented Jan 6, 2016

marked it as hi priority -> want to have that tuple<> go away, and also I should be able to have a way to format a column that that i can add pictures to it. Example: on the line column, if it's a new line, show a red dot or something.

@jtorjo
Copy link
Owner Author

jtorjo commented Jan 6, 2016

note: i need to be able to apply several column formatters to a given column (chain them)

question: does the formatter override the line color or not? do I want to have this as a parameter?

@jtorjo jtorjo added this to the 1.8 milestone Jan 11, 2016
@jtorjo
Copy link
Owner Author

jtorjo commented Feb 6, 2016

I have to say it - what I've done is insanely awesome 😃

@jtorjo jtorjo closed this as completed Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant