Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteratively resolving files paths could be slow #7

Open
juanca opened this issue Jul 13, 2016 · 1 comment
Open

Iteratively resolving files paths could be slow #7

juanca opened this issue Jul 13, 2016 · 1 comment

Comments

@juanca
Copy link
Owner

juanca commented Jul 13, 2016

Especially going through the possible gem paths.

Ohboy.

@juanca
Copy link
Owner Author

juanca commented Aug 2, 2018

After dealing with other tools for migrating a pretty big Rails application to Webpack modules, this is the best strategy (if this is even an issue):

For every known Rails modules path (vendor, gems, etc), get all the trees of files and use it as a lookup. This avoids attempting to read from disk many times. It also stresses the point that is loader should only be used as a transitionary tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant