Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter is incompatible with 0.6 #167

Closed
BlinkyStitt opened this issue Mar 30, 2020 · 7 comments
Closed

Formatter is incompatible with 0.6 #167

BlinkyStitt opened this issue Mar 30, 2020 · 7 comments

Comments

@BlinkyStitt
Copy link

I am trying to code in solidity 0.6, but the linter keeps removing my "override" lines. How do I stop it?

Alternatively, it looks like I can use the "next" version: protofire/solhint#170 (comment). Is there any way to do this? I don't see an option in settings.

@juanfranblanco
Copy link
Owner

Regarding the issue with override, this is a problem with prettier which is the formater prettier-solidity/prettier-plugin-solidity#221

@juanfranblanco
Copy link
Owner

@wysenynja Regarding prettier the best way is to either:

"to avoid prettier to mess with an unsuported keyword is to add the comment prettier-ignore before the line" as per the prettier guys suggestion.

or I have added now the support to simply disable formatting using the following setting:
image

Regarding the upgrade of Solhint I am awaiting confirmation that the package is ready to be integrated into vscode.

@BlinkyStitt
Copy link
Author

Thank you! I've disabled the formatter for now since there are a lot of lines affected. Looking forward to that issue being closed on prettier.

@BlinkyStitt BlinkyStitt changed the title Linter is incompatible with 0.6 Formatter is incompatible with 0.6 Apr 1, 2020
@BlinkyStitt
Copy link
Author

Actually, this shouldn't be closed yet. We should close it when prettier has fixed this issue and then vscode-solidity has been updated with their fix.

@BlinkyStitt BlinkyStitt reopened this Apr 1, 2020
@petejkim
Copy link

Is it possible to make this plugin just use the prettier and solhint that are installed in the current project? as opposed to using what's bundled in the extension?

@fvictorio
Copy link

@juanfranblanco I think prettier-solidity should work with 0.6 now.

@juanfranblanco
Copy link
Owner

Thanks @fvictorio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants