-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joss] Tests? #156
Comments
Hi @sneakers-the-rat ! Thanks for your feedback! I've been wanting to add unit tests for some time (#94). Otherwise, the core operations of the library can also be verified using the CLI interface: |
I'd be happy to make a pull request adding some tests as examples, if you haven't written them before :) |
That would be awesome, thank you! |
Here's an example test for the config: after installing with |
I offered to help with how to write tests! So am happy to answer questions/give examples here :) |
Test PR #237 has been merged and will be included in the next release (v0.10) |
Hey! Sorry for the long delay. just started a new job and things have been hectic.
Orienting myself to the package, and I can't seem to find any tests? JOSS doesn't have a minimum test coverage requirement or anything like that, but it does ask that essential functionality is tested, and I have interpreted that in the past as meaning unit tests that cover most of the major operations described in the docs and the paper.
I'll tag all my issues from the review with [joss] and also link back to the review so we can track them from there
Part of:
openjournals/joss-reviews#5266
The text was updated successfully, but these errors were encountered: