Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss][ux][minor] Catch KeyboardInterrupt in diart.stream #174

Closed
sneakers-the-rat opened this issue Oct 4, 2023 · 1 comment
Closed

[joss][ux][minor] Catch KeyboardInterrupt in diart.stream #174

sneakers-the-rat opened this issue Oct 4, 2023 · 1 comment
Labels
API Improvements to the API
Milestone
Version 0.8

Comments

@sneakers-the-rat
Copy link
Contributor

The diart.stream method seems to work well! when I exit with ctrl+c though it just crashes out - would be nice to add a try: ... except KeyboardInterrupt: here:

diart/src/diart/console/stream.py

Line 63 in 858cd1a

inference()

related to: openjournals/joss-reviews#5266
@sneakers-the-rat sneakers-the-rat mentioned this issue Oct 4, 2023
Closed
@juanmc2005 juanmc2005 added the API Improvements to the API label Oct 6, 2023
@juanmc2005 juanmc2005 added this to the Version 0.8 milestone Oct 6, 2023
@juanmc2005 juanmc2005 mentioned this issue Oct 11, 2023
Merged
@juanmc2005
Copy link
Owner

Implemented in #183

@juanmc2005 juanmc2005 mentioned this issue Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Improvements to the API
Projects
None yet
Milestone
Version 0.8
Development

No branches or pull requests
2 participants
@juanmc2005 @sneakers-the-rat