Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Level Prometheus Metrics and custom Grafana Dashboard #28

Closed
4 of 7 tasks
J12934 opened this issue Dec 31, 2019 · 1 comment
Closed
4 of 7 tasks

Application Level Prometheus Metrics and custom Grafana Dashboard #28

J12934 opened this issue Dec 31, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request in-progress Everything which is currently in the works

Comments

@J12934
Copy link
Member

J12934 commented Dec 31, 2019

Add prometheus metrics for information application level information like:

  • Number of registered teams
  • Number of logins (successful, failed)
  • Number of deleted instances
  • Number of challenges solved (Requires Scoreboard / Trainer Dashboard #27)
  • Http Response Codes (per path)[for Balancer and Proxied Requests]
  • Http Request Latency from JuiceShop (per path)[for Balancer and Proxied Requests]
  • Number of Requests requests proxied to the instances

The metrics endpoint should not be located at the usual /metrics but /balancer/metrics so that potential new JuiceShop Challenges(juice-shop/juice-shop#1275) are not hindered by this 😉.

A option should be added to the Helm Chart to enable / disable the endpoint.

The Helm Chart should provide a option to deploy a prometheus-operator ServiceMonitor for the /balancer/metrics endpoint.

The /balancer/metrics should also be secured using http basic auth. The credentials for it should be located in a kubernetes secrets to make it accessible to both the balancer and the ServiceMonitor.

To provide a baseline dashboard for the new metrics a grafana dashboard should be created and placed inside a specially labelled ConfigMap which can be picked up by the Grafana Sidecar: https://github.com/helm/charts/tree/master/stable/grafana#import-dashboards

@J12934 J12934 added the enhancement New feature or request label Dec 31, 2019
@J12934 J12934 added this to the Projects Summit - Winter 2020 milestone Dec 31, 2019
@J12934 J12934 self-assigned this Jan 25, 2020
@J12934 J12934 added the in-progress Everything which is currently in the works label Feb 27, 2020
@J12934
Copy link
Member Author

J12934 commented Feb 29, 2020

Will be release with 3.0.0 later today 😀

@J12934 J12934 closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress Everything which is currently in the works
Projects
None yet
Development

No branches or pull requests

1 participant