Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider tablets? iPad etc. #3

Closed
dy opened this issue Jan 26, 2018 · 3 comments · Fixed by #6
Closed

Consider tablets? iPad etc. #3

dy opened this issue Jan 26, 2018 · 3 comments · Fixed by #6

Comments

@dy
Copy link
Contributor

dy commented Jan 26, 2018 •
edited
Loading

Hi @juliangruber!

Your package is being used at plotly.js, but there seems to be a trouble detecting tablets, in particular plotly/plotly.js#280. Should this package consider tablet a mobile, or it is better to come up with a separate package is-tablet? Thank you!
@juliangruber
Copy link
Owner

This is a very interesting issue! Eventually I think there any distinguishing laptop / tablet / mobile will be useless, but for now, what about extending this api to be

isMobile() => isPhone() || isTablet()
isPhone()
isTablet()

@vkehayas
Copy link

Another user simply suggested replacing

ip(hone|od)
with
ip(ad|hone|od)

to add support for the ipad.

@juliangruber
Copy link
Owner

Does anyone want to take the lead on this?

@dy dy mentioned this issue Apr 12, 2018
Closed
@dy dy mentioned this issue Sep 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce tablets option dy/is-mobile
3 participants
@juliangruber @dy @vkehayas