Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect sqlline comments while line continuation and highlight #201

Closed
snuyanzin opened this issue Nov 15, 2018 · 6 comments
Closed

Respect sqlline comments while line continuation and highlight #201

snuyanzin opened this issue Nov 15, 2018 · 6 comments

Comments

@snuyanzin
Copy link
Collaborator

snuyanzin commented Nov 15, 2018

Currently sqlline support # and -- as sqlline comments but line continuation and highlight do not respect # and only partially respect --.
Moreover it would be nice to allow these comments not only from the first symbol of line but from the first symbol of trimmed line

@snuyanzin
Copy link
Collaborator Author

snuyanzin commented Nov 17, 2018

By the way here it is a short demo(sqlline syntax highlighting, dialect and line continuation) after this fix.
It looks like such demo is a better way to have understanding of what highlighting is in sqlline, than docs
https://asciinema.org/a/7fHnIDqqdmEk1ZoCBs9p3SAD2

@julianhyde
Copy link
Owner

julianhyde commented Nov 19, 2018

Fixed in dab3afb, PR #202. Thanks @snuyanzin!

(The demo is excellent, by the way!)

@snuyanzin
Copy link
Collaborator Author

Thank you.

About demo I have a suggestion to make something like jline3: demo page with a link to video. The demo could be changed a little bit (for instance there could be added prompt customization) or just added a new one

@julianhyde
Copy link
Owner

I like the idea of lots of small demos, each illustrating one or two features. Small demos are better for twitter.

We could have a demo page, but we could also just have a section on the main page. E.g. "There are demos of highlighting, connection management, line continuation, and (coming in 1.6!) prompts".

On the subject of project promotion: Have you considered submitting a conference talk on SQLLine? Aside from the promotion you would do at the conference, it would be great to have a video or slides on the site.

@snuyanzin
Copy link
Collaborator Author

Yes, agree, small demos make sense.
And agree about the main page.

Have you considered submitting a conference talk on SQLLine?

From one side yes, I thought about it, but from the other side the conference perhaps will be in Russian as most of them in Russia. The slides could be in English.

@julianhyde
Copy link
Owner

For conferences, do whatever is easiest for you. There's no harm in posting a video or slides in Russian - we might reach a new community!

Once you have a Russian talk under your belt, you could consider Berlin Buzzwords. It's an excellent conference, strong emphasis on open source, and not too long a flight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants