Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in README and maven repo #421

Closed
wants to merge 3 commits into from
Closed

typo in README and maven repo #421

wants to merge 3 commits into from

Conversation

laurentedel
Copy link
Contributor

setting Maven to 3.2.3 to pull dependencies through https + typo in readme

snuyanzin and others added 3 commits December 10, 2020 08:08
@snuyanzin
[SQLLINE-386] Support saved connections
a7d3a95 
1. Path to file with connections could be specified in connectionConfig property
2. Connections in a file have names, these names could be used as connection nicknames
3. Connections are allowed for both: input args and !connect command
4. !rereadconfconnections to reset connections loaded from file or use another file
5. !showconfconnections to read current connection file content
@laurentedel
Update pom.xml
43df872 
Maven 3.2.3 to avoid http dependencies pull error (https)
@laurentedel
Update README.md
971660a 
typo
@julianhyde
Copy link
Owner

What was the issue you experienced with maven 3.2.1?

@laurentedel
Copy link
Contributor Author

when building from scratch and using a Maven 3.2.1, I fell on the legacy http pathes which aren't allowed anymore

$ mvn package
[MVNVM] Using maven: 3.2.1
[MVNVM]             downloading: apache-maven-3.2.1-bin.zip
[MVNVM]                      to: /Users/lol/.mvnvm/apache-maven-3.2.1-bin.zip
[MVNVM]        preferred mirror: https://apache.mirrors.benatherton.com/maven/maven-3/3.2.1/binaries/apache-maven-3.2.1-bin.zip
[MVNVM]                 archive: https://archive.apache.org/dist/maven/maven-3/3.2.1/binaries/apache-maven-3.2.1-bin.zip
[MVNVM]               verifying: /Users/lol/.mvnvm/apache-maven-3.2.1-bin.zip
[MVNVM]              extracting: /Users/lol/.mvnvm/apache-maven-3.2.1
[INFO] Scanning for projects...
Downloading: http://repo.maven.apache.org/maven2/net/hydromatic/parent/0.1/parent-0.1.pom
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project sqlline:sqlline:1.10.0-SNAPSHOT (/Users/lol/temp/sqlline/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM: Could not transfer artifact net.hydromatic:parent:pom:0.1 from/to central (http://repo.maven.apache.org/maven2): Failed to transfer file: http://repo.maven.apache.org/maven2/net/hydromatic/parent/0.1/parent-0.1.pom. Return code is: 501 , ReasonPhrase:HTTPS Required. and 'parent.relativePath' points at wrong local POM @ line 4, column 11 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

Maven 3.2.3+ [3.2.3,) does enforce https by default.

@julianhyde
Copy link
Owner

Thank for the explanation, @laurentedel, and thank you for the PR.

Fixed in 9ff052d.

@julianhyde julianhyde closed this Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurentedel @julianhyde @snuyanzin