Custom prompt handler should apply even if there is no connection #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceMimosa
changed the title
|
Thanks for the contribution. For the benefit of people reading this case in future, can you describe what the problem was (i.e. how the prompt looked before you fixed it). Can you please write a test case. Maybe |
|
Add a unit test, please review. @julianhyde |
|
Thanks. I have added comments and cleaned up the code. Please review 3f25bfe. |
|
LGTM, thanks for your time to support this. |
|
Currently, the custom prompt handler is ignored until a connection is created; with no connection, prompt is always " Merged as 281b240. Thanks for the PR, @IceMimosa! |
julianhyde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom
PromptHandler#getDefaultPromptmay not work when there is no database connection.