Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The length of extra_data is calculated inconsistent with the document #297

Closed
lifani opened this issue Aug 9, 2019 · 2 comments
Closed

The length of extra_data is calculated inconsistent with the document #297

lifani opened this issue Aug 9, 2019 · 2 comments
Labels
Help wanted

Comments

@lifani
Copy link

lifani commented Aug 9, 2019

In the document "https://dev.mysql.com/doc/internals/en/rows-event.html#packet-Binlog::RowsEventExtraData" the length of extra_data is calculated as [extra_data_len - 2], but in the rows_event.py is calculated as [extra_data_len / 8]。Why？
@baloo
Copy link
Collaborator

baloo commented Aug 21, 2019

no idea, but feel free to throw a PR to fix that :)

@dongwook-chan
Copy link
Collaborator

@lifani
This issue was fixed in #355 and released in version 0.26.

@baloo baloo closed this as completed Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baloo @lifani @dongwook-chan