Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor print.jl into a print subfolder? #550

Closed
IainNZ opened this issue Aug 27, 2015 · 3 comments
Closed

Refactor print.jl into a print subfolder? #550

IainNZ opened this issue Aug 27, 2015 · 3 comments

Comments

@IainNZ
Copy link
Collaborator

IainNZ commented Aug 27, 2015

I did some local tinkering when trying to improve compilation times to break up the container printing into more self contained functions, but didn't include because it seemed marginal and could have made rebased OneIndexedArrays harder.

I'm thinking that it could be a good idea to do that anyway, just to improve maintainability (especially now its arguably even more complex), but I'd also want to break it up into files at the same time. I didn't want to do that unilaterally though.

churn

@joehuchette
Copy link
Contributor

I don't mind unilateral if it means I don't have to touch the printing code :)

I agree it could use some refactoring; it's pretty inscrutable for me, and I feel like my changes to it have been somewhat hacky because of that. So have at it.

@mlubin
Copy link
Member

mlubin commented Aug 27, 2015

Fine with me

@mlubin
Copy link
Member

mlubin commented Dec 11, 2016

This never happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants