Recent matrix changes broke JuMPeR

[IainNZ]

using JuMP, JuMPeR
m = RobustModel()
@defVar(m, matvar[1:3,1:3])
@defUnc(m, vecunc[1:3])
@defUnc(m, matunc[1:3,1:3])

b = [1,2,3]
A = eye(3,3)
c = @addConstraint(m, A*vecunc .== b)

julia> c = @addConstraint(m, A*vecunc .== b)
ERROR: MethodError: `addVectorizedConstraint` has no method matching addVectorizedConstraint(::JuMP.Model, ::Array{Any,1})
Closest candidates are:
  addVectorizedConstraint(::JuMP.Model, ::Array{JuMP.GenericRangeConstraint{JuMP.GenericAffExpr{Float64,JuMP.Variable}},N})
  addVectorizedConstraint(::JuMP.Model, ::Array{JuMP.GenericQuadConstraint{JuMP.GenericQuadExpr{Float64,JuMP.Variable}},N})
  addVectorizedConstraint(::JuMP.Model, ::Array{JuMP.GenericRangeConstraint{JuMP.GenericAffExpr{Float64,JuMPeR.Uncertain}},N})
  ...

[IainNZ]

As you can see, I have the correct addVectorizedConstraint method defined, but something went screwy with the container. Ideas?

[joehuchette]

Which commit is this on?

[IainNZ]

commit d14145b2911125e572ee40c66db679e7872299a6
Author: Joey Huchette <joehuchette@gmail.com>
Date:   Sat Sep 5 14:11:44 2015 -0400

    generalize addToExpression (0 -> zero(C))

JuMPeR any version (e.g. released version v0.2.0 or master)

[joehuchette]

We should have a fallback method for addVectorizedConstraint that handles this. However, it seems that A*vecunc - b is giving an Array{Any}, which is also an issue. It's falling back to a method in arraymath.jl in Base.

[IainNZ]

Something I haven't defined maybe?

[joehuchette]

Should still hopefully work, though.

[joehuchette]

julia> Base.promote_type(eltype(A*matvar), eltype(b))
JuMP.GenericAffExpr{Float64,JuMP.Variable}

julia> Base.promote_type(eltype(A*matunc), eltype(b))
Any

[joehuchette]

You need to add the equivalent of

Base.promote_rule{R<:Real}(::Type{Variable},::Type{R}       ) = AffExpr
Base.promote_rule(         ::Type{Variable},::Type{AffExpr} ) = AffExpr
Base.promote_rule(         ::Type{Variable},::Type{QuadExpr}) = QuadExpr
Base.promote_rule{R<:Real}(::Type{AffExpr}, ::Type{R}       ) = AffExpr
Base.promote_rule(         ::Type{AffExpr}, ::Type{QuadExpr}) = QuadExpr
Base.promote_rule{R<:Real}(::Type{QuadExpr},::Type{R}       ) = QuadExpr

to JuMPeR, I think.

[IainNZ]

Got it, will try that now

[IainNZ]

Success! Close this, or is it worth adding the fallback?

[joehuchette]

I'm (hoping) we can solve this completely in JuMP, actually...

[mlubin]

Fixed?

[IainNZ]

Yep, and tagged