Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .zip upload of knitro14 in CI #284

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Use .zip upload of knitro14 in CI #284

wants to merge 24 commits into from

Conversation

odow
Copy link
Member

@odow odow commented Feb 29, 2024

@odow odow changed the title Use tar.b2 upload of libknitro in CI to reduce filesize Use tar.bz2 upload of libknitro in CI to reduce filesize Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (ae2eab0) to head (2f4a159).

❗ Current head 2f4a159 differs from pull request most recent head d957530. Consider uploading reports for the commit d957530 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   84.61%   84.60%   -0.02%     
==========================================
  Files           3        3              
  Lines        1001     1000       -1     
==========================================
- Hits          847      846       -1     
  Misses        154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow changed the title Use tar.bz2 upload of libknitro in CI to reduce filesize Use .zip upload of knitro14 in CI Mar 12, 2024
@odow
Copy link
Member Author

odow commented Mar 12, 2024

cc @amontoison I guess we need to rebuild libknitro.jl for v14?

I assume the sigabrts mean that we're calling some part of the C API wrong:

image

test/MOI_wrapper.jl Outdated Show resolved Hide resolved
@odow
Copy link
Member Author

odow commented Mar 18, 2024

These segfaults are in the middle of KN_solve, and they are for a linear problem. I think this might be a bug in KNITRO? We're not doing anything to trigger this.

How did you build the zip? Are we missing anything else?

@amontoison
Copy link
Collaborator

amontoison commented Mar 18, 2024

These segfaults are in the middle of KN_solve, and they are for a linear problem. I think this might be a bug in KNITRO? We're not doing anything to trigger this.

How did you build the zip? Are we missing anything else?

I just did an archive with the shared libraries of the four platforms.
We should check with ldd that libiompi is the only dependency of libknitro.
I highly suspect a bug in KNITRO, we should comment the linear problem to see if it's the only issue.

@amontoison
Copy link
Collaborator

@odow I prepared a KNITRO_jll.jl for us to simplify running CI scripts.
This will make it easier to run CI with new releases.
We just need to patch the file src/KNITRO.jl and update the Project.toml with the local JLL.
My local branch is here.

@odow
Copy link
Member Author

odow commented Nov 3, 2024

Where does KNITRO_jll come from?

@amontoison
Copy link
Collaborator

amontoison commented Nov 3, 2024

I created it myself without BinaryBuilder.
It' an alternative to an archive of shared libraries on a google drive for CI.
Note that we can only use it for CI because it contains the shared libraries like the official HSL_jll.jl.

@odow
Copy link
Member Author

odow commented Nov 3, 2024

Why is it 500 Mb?

@amontoison
Copy link
Collaborator

amontoison commented Nov 3, 2024

Because it contains libknitro.$dlext and the binary amplexe for the four main platforms.
I also added the three binaries related to the license directly in the JLL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants