-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-factor promote_operation and operate #2203
Comments
Yes, I added them gradually whenever one was needed by a bridge but it would be nice to have a more structured list of what's functions should implement which is useful when defining a new function and what bridges can expect functions have implemented so that you know what you can use when writing a bridge. |
I've been looking into I haven't quite figured out a sensible approach yet. |
To update this:
|
Closing because this is now a lot cleaner. |
There are a bunch of rules for various
promote_operation
andoperate
.MathOptInterface.jl/src/Utilities/functions.jl
Lines 1597 to 1610 in 6b2192a
MathOptInterface.jl/src/Utilities/functions.jl
Lines 1697 to 1715 in 6b2192a
Defining a new function is really hard because it requires whack-a-mole: #2201
I think we need an explicit write up of what functions are implemented, along with tests, so that we can check everything is working as intended.
The text was updated successfully, but these errors were encountered: