Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileFormats.LP] write a proper parser #2351

Open
odow opened this issue Nov 16, 2023 · 5 comments
Open

[FileFormats.LP] write a proper parser #2351

odow opened this issue Nov 16, 2023 · 5 comments
Labels
Submodule: FileFormats About the FileFormats submodule Type: Bug
Milestone

Comments

@odow
Copy link
Member

odow commented Nov 16, 2023

The LP reader is a source of many problems because it was designed as a bit of a hack and doesn't follow any formal grammar. It's probably time we rewrote a proper implementation.

https://discourse.julialang.org/t/sos-constraints-in-lp-file-throwing-malformed-sos-constraint-error/106324

See also: https://github.com/jump-dev/MathOptInterface.jl/issues?q=is%3Aissue+FileFormats.LP+is%3Aclosed

cc @hdavid16

@odow odow added Type: Bug Submodule: FileFormats About the FileFormats submodule labels Nov 16, 2023
@pedromxavier
Copy link
Contributor

@rafabench I think this might be interesting for some of our applications, right?

@odow
Copy link
Member Author

odow commented Nov 20, 2023

To clarify, you can read LP files currently. But the reader is not robust to the wide variety of LP files in the wild.

@pedromxavier
Copy link
Contributor

We have already used this LP reader in some apps. I remember to have discussed it with my coworkers some months ago.

@rafabench
Copy link

@rafabench I think this might be interesting for some of our applications, right?

Yes! It's always good to have a robust LP reader/writer.

@odow
Copy link
Member Author

odow commented Oct 23, 2024

See also #2563

The parser should not read line-by-line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submodule: FileFormats About the FileFormats submodule Type: Bug
Development

No branches or pull requests

3 participants