Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of ListOfNonstandardBridges #309

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Mar 3, 2025

This is now checked
jump-dev/MathOptInterface.jl#2665
so SCS does not even precompile

ERROR: LoadError: TypeError: in typeassert, expected Vector{Type}, got a value of type Vector{UnionAll}
Stacktrace:
  [1] get(model::MathOptInterface.Utilities.CachingOptimizer{SCS.Optimizer, MathOptInterface.Utilities.UniversalFallback{MathOptInterface.Utilities.Model{Float64}}}, attr::MathOptInterface.Bridges.ListOfNonstandardBridges{Float64})
    @ MathOptInterface.Utilities ~/.julia/packages/MathOptInterface/yI6C0/src/Utilities/cachingoptimizer.jl:1047
  [2] full_bridge_optimizer(model::MathOptInterface.Utilities.CachingOptimizer{SCS.Optimizer, MathOptInterface.Utilities.UniversalFallback{MathOptInterface.Utilities.Model{Float64}}}, ::Type{Float64})
    @ MathOptInterface.Bridges ~/.julia/packages/MathOptInterface/yI6C0/src/Bridges/Bridges.jl:58
  [3] instantiate(optimizer_constructor::Any; with_bridge_type::Type{Float64}, with_cache_type::Nothing)
    @ MathOptInterface ~/.julia/packages/MathOptInterface/yI6C0/src/instantiate.jl:190
  [4] macro expansion
    @ ~/.julia/dev/SCS/src/SCS.jl:33 [inlined]
  [5] macro expansion
    @ ~/.julia/packages/PrecompileTools/L8A3n/src/workloads.jl:78 [inlined]

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.76%. Comparing base (d1a2d70) to head (0391c10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files           8        8           
  Lines         433      433           
=======================================
  Hits          419      419           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat merged commit 97da3e2 into master Mar 3, 2025
12 checks passed
@blegat blegat deleted the bl/list-of-nonstandard branch March 3, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant