-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weird break #47
Comments
Ha, thanks for pointing it out. It looks like the line is dead code that's never executed due to the prior condition: https://github.com/junegunn/vim-easy-align/blob/master/autoload/easy_align.vim#L926-L927 |
You will leave syntax error codes because they are unreachable? |
Of course not :) |
Removed the line. Thanks. Are you reviewing the code? This was my first non-trivial Vim plugin, so I presume you'll find lots of non-idiomatic code lurking in there! ;) |
I'm reading codes of some plugins. Before reading I always run vimlint (https://github.com/syngan/vim-vimlint) through all the codes of that plugin. But be glad, this is the only fatal mistake that vimlint warned. |
I found a
break
atautoload/easy_align.vim
line 846, withoutwhile
orfor
statement.The text was updated successfully, but these errors were encountered: