refactor: validate additional classpath entries directly instead of using filtered list

Author: currenjin

junit-platform-console/src/main/java/org/junit/platform/console/tasks/DiscoveryRequestCreator.java

@@ -92,7 +92,7 @@ private static Set<Path> determineClasspathRoots(TestDiscoveryOptions options) {
 			() -> "No classpath entries selected");
 		if (selectedClasspathEntries.isEmpty()) {
 			Set<Path> rootDirs = new LinkedHashSet<>(ReflectionUtils.getAllClasspathRootDirectories());
-			rootDirs.addAll(options.getExistingAdditionalClasspathEntries());
+			rootDirs.addAll(options.getAdditionalClasspathEntries());
 			return validateAndLogInvalidRoots(rootDirs);
 		}
 		return validateAndLogInvalidRoots(new LinkedHashSet<>(selectedClasspathEntries));

platform-tests/src/test/java/org/junit/platform/console/tasks/DiscoveryRequestCreatorTests.java

@@ -391,15 +391,17 @@ void logsInvalidSearchPathRoots(@TrackLogRecords LogRecordListener listener) {
 	}
 
 	@Test
-	void doesNotLogInvalidAdditionalClasspathRoots(@TrackLogRecords LogRecordListener listener) {
+	void logsInvalidAdditionalClasspathRoots(@TrackLogRecords LogRecordListener listener) {
 		var opts = new TestDiscoveryOptions();
 		opts.setScanClasspath(true);
 		opts.setAdditionalClasspathEntries(List.of(Paths.get("/also/does/not/exist")));
 
 		DiscoveryRequestCreator.toDiscoveryRequestBuilder(opts);
 
-		assertThat(listener.stream(DiscoveryRequestCreator.class)).map(LogRecord::getMessage).filteredOn(
-			msg -> msg.contains("/also/does/not/exist")).isEmpty();
+		assertThat(listener.stream(DiscoveryRequestCreator.class))
+				.map(LogRecord::getMessage)
+				.filteredOn(msg -> msg.contains("/also/does/not/exist"))
+				.hasSize(1);
 	}
 
 	private LauncherDiscoveryRequest convert() {