Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated since jdk9 replacing constructor instance of Double and Float #1660

Merged
merged 2 commits into from
Aug 2, 2020

Conversation

RahulNagekar
Copy link
Contributor

No description provided.

@marcphilipp
Copy link
Member

Can't we simply rely on autoboxing?

@RahulNagekar
Copy link
Contributor Author

Can't we simply rely on autoboxing?

Right, good point.

@kcooney
Copy link
Member

kcooney commented Apr 19, 2020

@marcphilipp @RahulNagekar I personally prefer not using autoboxing here. Having an explicit conversion here makes it clear to future readers that a conversion is happening.

@stefanbirkner
Copy link
Contributor

I'm also in favour for Double.valueOf so that the code is the same like in JUnit 4's Assert.

@RahulNagekar
Copy link
Contributor Author

I currently not sure if autoboxing would be more beneficial or valueOf (performance-wise).
As valueOf is used at many places in this file, I say keep it the same to preserve consistency in code.
:-)

@stefanbirkner stefanbirkner added this to the 4.13.1 milestone Apr 25, 2020
@marcphilipp marcphilipp changed the base branch from master to main June 21, 2020 17:05
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants