junit5 console launcher doesn't run Junit4 tests

[k-bhavitha]

I've forked this https://github.com/junit-team/junit5-samples/tree/master/junit5-jupiter-starter-ant

I then added a sample Junit4 test under test junit5-jupiter-starter-ant/src/test/java/com/example/project/

Launcher o/p:
Ran the build.sh expecting the vintage engine to show the run o/p.

My new class is not being picked by vintage

[sormuras]

Thanks for creating this new issue and providing more details.

One more question: what is the file/class name of you JUnit 4 test?

[k-bhavitha]

CalculatorJunit4Tests.java

[sormuras]

Okay, the s is at the end. If you want to include classes ending with Test you need to include them like:

        <junitlauncher haltOnFailure="true" printSummary="true">
            <classpath refid="test.classpath"/>
            <testclasses outputdir="build/test-report">
                <fileset dir="build/test">
                    <include name="**/*Tests.class"/>
                    <include name="**/*Test.class"/>
                </fileset>
...

Now to the content of CalculatorJunit4Tests.java. Can you please post it here, too?

[sormuras]

Looks like <junitlauncher> is started twice. Could be an issue with the task implementation.

[k-bhavitha]

package com.example.project;

import org.junit.Test;
class CalculatortJunit4Tests{
@Test(expected = AssertionError.class)
public void assertErrorOldStyle() 	{throw new AssertionError(); 	}
}

[sormuras]

JUnit 3 and 4 classes need to be public.
@test is lower-case?! Added formatting your post. See https://guides.github.com/features/mastering-markdown/ for formatting features.

[k-bhavitha]

Thanks! that worked..but a quick question
Are we not supposed to add the vintage jars/jupiter for junitlauncher task ?
How is that working without any

[sormuras]

Are we not supposed to add the vintage jars for junitlauncher task ?

Yes, we are, and we do. Via the JUnit 5 standalone distribution "all-deps-are-in" happy jar being copied to the ${ANT_HOME}/lib directory by the build.sh script:

junit5-samples/junit5-jupiter-starter-ant/build.sh

Line 20 in 29fd8a5

wget --timestamping --continue --directory-prefix "${ant_folder}/lib" "http://central.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/${junit_platform_version}/junit-platform-console-standalone-${junit_platform_version}.jar"

This standalone jar contains all what it is needed to run Jupiter and Vintage (JUnit 3 + 4) tests.

[k-bhavitha]

Great! Thanks

[sormuras]

You're welcome.