Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mechanism to stop test run with first failing test #1729

Closed
jlink opened this issue Jan 12, 2019 · 5 comments
Closed

Introduce mechanism to stop test run with first failing test #1729

jlink opened this issue Jan 12, 2019 · 5 comments

Comments

@jlink
Copy link
Contributor

jlink commented Jan 12, 2019

Subject says it all. Would be especially useful for TCR (test && commit || reset) workflow.
Feature could be globally configured or switched of from IDE / build tool.

#431 is related and pitest/pitest-junit5-plugin#15 might also profit.

@marcphilipp
Copy link
Member

I wonder if/how this could be implemented on the platform level. I guess we could provide a platform feature to enable it and add a isStopped() method to ExecutionRequest which engines should check before starting a execution of a new test. Thoughts?

@jlink
Copy link
Contributor Author

jlink commented Jan 12, 2019

You're right, a new channel from platform to engine is needed to signal the stop. I wonder if such a channel could be used for other useful stuff as well...

The simplest solution I can think of, however, is System.exit. I'm not sure, though, what kind of adverse effects that might bring.

@marcphilipp
Copy link
Member

Since build tools/IDEs run in the same JVM I don't think that would be a viable solution. Moreover, even if a test run's being cancelled, we should stick to the contracts in TestExecutionListener.

@stale
Copy link

stale bot commented May 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the status: stale label May 13, 2021
@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically closed due to inactivity. If you have a good use case for this feature, please feel free to reopen the issue.

@stale stale bot closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants