Skip to content

Introduce feature flag for auto-closing AutoCloseable in Jupiter's ExtensionContext.Store #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 28, 2025

Conversation

YongGoose
Copy link
Contributor

@YongGoose YongGoose commented Apr 6, 2025

Overview

fix #4434


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong
Add tests

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong
YongGoose and others added 6 commits April 9, 2025 21:28

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…r/ResourceAutoClosingTests.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong
@YongGoose YongGoose marked this pull request as ready for review April 9, 2025 14:18
@YongGoose YongGoose requested a review from marcphilipp April 9, 2025 14:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
YongGoose and others added 3 commits April 15, 2025 18:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…scriptor/AbstractExtensionContext.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…scriptor/AbstractExtensionContext.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>
YongGoose and others added 7 commits April 15, 2025 19:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…scriptor/AbstractExtensionContext.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…scriptor/AbstractExtensionContext.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…scriptor/AbstractExtensionContext.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…nfig/JupiterConfiguration.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…nfig/JupiterConfiguration.java

Co-authored-by: Marc Philipp <mail@marcphilipp.de>

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong
@YongGoose YongGoose requested a review from marcphilipp April 15, 2025 10:46
polishing

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong

Verified

This commit was signed with the committer’s verified signature.
YongGoose Yongjun Hong
YongGoose and others added 4 commits April 18, 2025 16:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
marcphilipp Marc Philipp

Verified

This commit was signed with the committer’s verified signature.
marcphilipp Marc Philipp
@marcphilipp marcphilipp merged commit 1d81839 into junit-team:main Apr 28, 2025
13 checks passed
@marcphilipp
Copy link
Member

Thanks again, @YongGoose! 👍

@YongGoose
Copy link
Contributor Author

YongGoose commented Apr 28, 2025

Thanks again, @YongGoose! 👍

I'm very happy to have you back!
During the Easter holiday, I created a few issues and pull requests and left some comments.

I'd appreciate it if you could take a look and share your feedback whenever you have time. 😀

@YongGoose
Copy link
Contributor Author

Thanks again, @YongGoose! 👍

I'm very happy to have you back! During the Easter holiday, I created a few issues and pull requests and left some comments.

I'd appreciate it if you could take a look and share your feedback whenever you have time. 😀

@marcphilipp

When you have time, I'd appreciate your feedback on the issue and PR!

@marcphilipp
Copy link
Member

@YongGoose It's on my (growing) list to discuss with the team. I'll get back to you as soon as possible. Sorry for the delay!

@YongGoose
Copy link
Contributor Author

@YongGoose It's on my (growing) list to discuss with the team. I'll get back to you as soon as possible. Sorry for the delay!

Thank you! I hope there’s not too much for the team to discuss… 🥹
And as always, thank you for all the work you do for the JUnit 5 community.

@YongGoose
Copy link
Contributor Author

Hello @marcphilipp!!
Would it be okay to ask if the issue and PR mentioned in this comment fall within the scope of team meeting?

@marcphilipp
Copy link
Member

Sorry, those are still in the "discussion backlog". Sorry for making you wait! 😕

@YongGoose
Copy link
Contributor Author

Sorry, those are still in the "discussion backlog". Sorry for making you wait! 😕

Not at all!

I recently became a committer for the apache/seata project, and I’m doing code reviews there based on the testing practices I learned while working with you.

Thanks to you, I’ve learned so much and achieved something meaningful.
Thank you! 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce feature flag for auto-closing AutoCloseable in Jupiter's ExtensionContext.Store
2 participants