Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-collectable resources in Exposer #716

Open
aeroyorch opened this issue Jun 9, 2024 · 0 comments
Open

Non-collectable resources in Exposer #716

aeroyorch opened this issue Jun 9, 2024 · 0 comments

Comments

@aeroyorch
Copy link

aeroyorch commented Jun 9, 2024

Hi!

We would like to serve additional non-Prometheus resources under the same HTTP server (e.g. typical health check (/healthz) and readiness (/readyz) endpoints) along with the metrics resources, without loosing the current functionality provided by the Exposerclass.

One possible solution would be using std::shared_ptr instead of std::unique_ptr to store the server_ member and having an additional constructor that accepts the provision of an externally managed CivetServer.

Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant