Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/replace URI utilities with dedicated type #410

Open
bollwyvl opened this issue Nov 16, 2020 · 0 comments
Open

Refactor/replace URI utilities with dedicated type #410

bollwyvl opened this issue Nov 16, 2020 · 0 comments

Comments

@bollwyvl
Copy link
Collaborator

Elevator Pitch

We should

  • accept a dependency on an external URI library
  • get one into JupyterLab/lumino
  • write our own
    To handle various URI-related tasks.

Motivation

#403 (with work on #406) demonstrated how easy it is to mess up URIs vs ContentsManager paths (which are not URI-encoded). We have a fair amount of places where we do string manipulation on URIs, which is almost never safe.

Design Ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant