Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kernel specific metrics to nbresuse #40

Closed
Gsbreddy opened this issue May 19, 2020 · 5 comments
Closed

Adding kernel specific metrics to nbresuse #40

Gsbreddy opened this issue May 19, 2020 · 5 comments

Comments

@Gsbreddy
Copy link

Hi All,
I have implemented the solution to capture kernel specific prometheus metrics and would like to contribute back.

Please let me know if it's ok to raise a PR.

Thank you.

@jtpio
Copy link
Member

jtpio commented May 20, 2020

Thanks @Gsbreddy.

I guess it sounds similar to what is being discussed in #31?

A PR would be very appreciated as this is a feature many would be interested in! (maybe worth checking the prior work linked in #31 too)

@Gsbreddy
Copy link
Author

Yes @jtpio , I have referred this and implemented as needed. I am attaching a sample metrics collected.

hubmetrics.txt

This contribution just adds per kernel prometheus metrics as shown in file.I will raise a PR if this looks good. Once this is done, I will think of working on some items mentioned in #31.

@jtpio
Copy link
Member

jtpio commented May 20, 2020

Nice, thanks @Gsbreddy!

@Gsbreddy
Copy link
Author

I have raised PR @jtpio

@jtpio
Copy link
Member

jtpio commented Jun 17, 2020

Closing as duplicate of #31 (to keep the conversation in one place).

@jtpio jtpio closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants